Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-8_x] Restrict Angular SSR to paths in the sitemap #3877

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

dspace-bot
Copy link
Contributor

Port of #3682 by @alanorth to dspace-8_x.

Because Angular SSR is not very efficient, after discussion with
the Google Scholar team we realized a compromise would be to only
use SSR for pages in the DSpace sitemap (and the home page).

(cherry picked from commit 5b3b3bf)
@dspace-bot dspace-bot added bug high priority performance / caching Related to performance, caching or embedded objects labels Jan 21, 2025
@tdonohue tdonohue added this to the 8.1 milestone Jan 21, 2025
@tdonohue
Copy link
Member

Merging as this passes all automated tests (including the test that verifies SSR is still working on /home)

@tdonohue tdonohue merged commit 7f1a21b into dspace-8_x Jan 22, 2025
15 checks passed
@tdonohue tdonohue deleted the backport-3682-to-dspace-8_x branch January 22, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high priority performance / caching Related to performance, caching or embedded objects
Projects
Development

Successfully merging this pull request may close these issues.

3 participants